Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JWT getEntityQuery #2013

Merged
merged 8 commits into from
Jul 24, 2020
Merged

Add JWT getEntityQuery #2013

merged 8 commits into from
Jul 24, 2020

Conversation

burn2delete
Copy link
Contributor

@burn2delete burn2delete commented Jul 13, 2020 •
edited by daffl
Loading

Brings both local-strategy and jwt-strategy into alignment.

Added getEntityQuery to JWT strategy, allows extending JWT class to include additional query parameters in entity lookup.

Closes #2007

@burn2delete burn2delete mentioned this pull request Jul 13, 2020
Closed
@daffl
Copy link
Member

daffl commented Jul 24, 2020

Alright, I updated it so that getEntityQuery goes back to the default behaviour since it looked like it was a regression for some people. Basically what you should be able to do now is customize the strategy and change getEntityQuery to return the query object you need based on the original params.

@daffl daffl merged commit e0e7fb5 into feathersjs:crow Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue authenticating user via JWT when users service requires query params
2 participants
@burn2delete @daffl